-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/storage-vm: Add test for live resizing of VM disks with zfs or lvm pool driver #310
base: main
Are you sure you want to change the base?
Conversation
2c097a8
to
3f6a581
Compare
db901b4
to
aa33380
Compare
aa33380
to
c9ec1f2
Compare
…lvm pool driver Signed-off-by: Kadin Sayani <[email protected]>
c9ec1f2
to
4dda3e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If all storage drivers are to grow support for live resize then the extension name will change before landing in LXD.
As for the testing logic, it looks good to me even if I've not seen it in action for the LIVE_GROWING_SUPPORTED=1
case.
Let's wait for live resize support for all storage drivers.
This PR adds a test for canonical/lxd#14211. The test depends on presence of the feature which is indicated by the api extensions
vm_zfs_storage_disk_live_resize
andvm_lvm_storage_disk_live_resize
.